synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: dial the remote socket continually until connect (#6891)

Browse Source 
It's possible that the command starts but the socket isn't ready
even when the file exists.
This commit is contained in:
Kyle Carberry
2023-03-30 10:36:23 -05:00
committed by GitHub
parent 5686fc9983
commit 04e404e448
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
agent/agent_test.go
View File

@ -673,13 +673,14 @@ func TestAgent_UnixRemoteForwarding(t *testing.T) {
err = cmd.Start() err = cmd.Start()
require.NoError(t, err) require.NoError(t, err)
// It's possible that the socket is created but the server is not ready to
// accept connections yet. We need to retry until we can connect.
var conn net.Conn
require.Eventually(t, func() bool { require.Eventually(t, func() bool {
_, err := os.Stat(remoteSocketPath) var err error
conn, err = net.Dial("unix", remoteSocketPath)
return err == nil return err == nil
}, testutil.WaitLong, testutil.IntervalFast) }, testutil.WaitShort, testutil.IntervalFast)
conn, err := net.Dial("unix", remoteSocketPath)
require.NoError(t, err)
defer conn.Close() defer conn.Close()
_, err = conn.Write([]byte("test")) _, err = conn.Write([]byte("test"))
require.NoError(t, err) require.NoError(t, err)