synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: add OpenIn option to coder_app (#15743)

Browse Source 
This PR is the coder/coder part of [the open_in parameter
issue](https://github.com/coder/terraform-provider-coder/issues/297)
aiming to add a new optional parameter to choose how to open modules.

This PR is heavily linked [to this
PR](https://github.com/coder/terraform-provider-coder/pull/321).

ℹ️ For now, some integrations tests can not be pushed as it requires a
release on the terraform-provider repo.
This commit is contained in:
Vincent Vielle
2025-01-03 11:27:02 +01:00
committed by GitHub
parent 3f1795fd92
commit 08463c27d8
34 changed files with 1075 additions and 800 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
provisioner/terraform/resources_test.go
View File

@ -182,6 +182,7 @@ func TestConvertResources(t *testing.T) {
DisplayName: "app1",
// Subdomain defaults to false if unspecified.
Subdomain: false,
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
{
Slug: "app2",
@ -192,11 +193,13 @@ func TestConvertResources(t *testing.T) {
Interval: 5,
Threshold: 6,
},
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
{
Slug: "app3",
DisplayName: "app3",
Subdomain: false,
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
},
Auth: &proto.Agent_Token{},
@ -217,10 +220,12 @@ func TestConvertResources(t *testing.T) {
{
Slug: "app1",
DisplayName: "app1",
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
{
Slug: "app2",
DisplayName: "app2",
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
},
Auth: &proto.Agent_Token{},
@ -243,6 +248,7 @@ func TestConvertResources(t *testing.T) {
DisplayName: "app1",
// Subdomain defaults to false if unspecified.
Subdomain: false,
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
{
Slug: "app2",
@ -253,6 +259,7 @@ func TestConvertResources(t *testing.T) {
Interval: 5,
Threshold: 6,
},
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
},
Auth: &proto.Agent_Token{},
@ -271,6 +278,7 @@ func TestConvertResources(t *testing.T) {
Slug: "app3",
DisplayName: "app3",
Subdomain: false,
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
},
Auth: &proto.Agent_Token{},
@ -454,6 +462,7 @@ func TestConvertResources(t *testing.T) {
Slug: "code-server",
DisplayName: "code-server",
Url: "http://localhost:13337?folder=/home/coder",
OpenIn: proto.AppOpenIn_SLIM_WINDOW,
},
},
Auth: &proto.Agent_Token{},