synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-15 22:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Wait for WorkspaceResources to complete before exiting (#1149)

Browse Source 
This caused a flake seen in:
https://github.com/coder/coder/runs/6162655678?check_suite_focus=true#step:9:87
This commit is contained in:
Kyle Carberry
2022-04-25 13:11:35 -05:00
committed by GitHub
parent 1e6f2cf750
commit 09405ddc40
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cli/cliui/resources_test.go
View File

@ -17,6 +17,7 @@ func TestWorkspaceResources(t *testing.T) {
t.Run("SingleAgentSSH", func(t *testing.T) { t.Run("SingleAgentSSH", func(t *testing.T) {
t.Parallel() t.Parallel()
ptty := ptytest.New(t) ptty := ptytest.New(t)
done := make(chan struct{})
go func() { go func() {
err := cliui.WorkspaceResources(ptty.Output(), []codersdk.WorkspaceResource{{ err := cliui.WorkspaceResources(ptty.Output(), []codersdk.WorkspaceResource{{
Type: "google_compute_instance", Type: "google_compute_instance",
@ -32,14 +33,17 @@ func TestWorkspaceResources(t *testing.T) {
WorkspaceName: "example", WorkspaceName: "example",
}) })
require.NoError(t, err) require.NoError(t, err)
close(done)
}() }()
ptty.ExpectMatch("coder ssh example") ptty.ExpectMatch("coder ssh example")
<-done
}) })
t.Run("MultipleStates", func(t *testing.T) { t.Run("MultipleStates", func(t *testing.T) {
t.Parallel() t.Parallel()
ptty := ptytest.New(t) ptty := ptytest.New(t)
disconnected := database.Now().Add(-4 * time.Second) disconnected := database.Now().Add(-4 * time.Second)
done := make(chan struct{})
go func() { go func() {
err := cliui.WorkspaceResources(ptty.Output(), []codersdk.WorkspaceResource{{ err := cliui.WorkspaceResources(ptty.Output(), []codersdk.WorkspaceResource{{
Transition: database.WorkspaceTransitionStart, Transition: database.WorkspaceTransitionStart,
@ -82,9 +86,11 @@ func TestWorkspaceResources(t *testing.T) {
HideAccess: false, HideAccess: false,
}) })
require.NoError(t, err) require.NoError(t, err)
close(done)
}() }()
ptty.ExpectMatch("google_compute_disk.root") ptty.ExpectMatch("google_compute_disk.root")
ptty.ExpectMatch("google_compute_instance.dev") ptty.ExpectMatch("google_compute_instance.dev")
ptty.ExpectMatch("coder ssh dev.postgres") ptty.ExpectMatch("coder ssh dev.postgres")
<-done
}) })
} }