From 09f87d1df112b5868074b3f036ace7792274bbf2 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Mon, 6 Mar 2023 21:13:08 -0600 Subject: [PATCH] chore: remove empty case for metricscache (#6473) This wasn't necessary to test and just caused flakes. See: https://github.com/coder/coder/actions/runs/4350034299/jobs/7600340648 --- coderd/metricscache/metricscache_test.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/coderd/metricscache/metricscache_test.go b/coderd/metricscache/metricscache_test.go index 98190ac4f4..e8e3a3e9cf 100644 --- a/coderd/metricscache/metricscache_test.go +++ b/coderd/metricscache/metricscache_test.go @@ -173,10 +173,6 @@ func TestCache_TemplateUsers(t *testing.T) { Provisioner: database.ProvisionerTypeEcho, }) - gotUniqueUsers, ok := cache.TemplateUniqueUsers(template.ID) - require.False(t, ok, "template shouldn't have loaded yet") - require.EqualValues(t, -1, gotUniqueUsers) - for _, row := range tt.args.rows { row.TemplateID = template.ID db.InsertWorkspaceAgentStat(context.Background(), row) @@ -189,7 +185,7 @@ func TestCache_TemplateUsers(t *testing.T) { "TemplateDAUs never populated", ) - gotUniqueUsers, ok = cache.TemplateUniqueUsers(template.ID) + gotUniqueUsers, ok := cache.TemplateUniqueUsers(template.ID) require.True(t, ok) gotEntries, ok := cache.TemplateDAUs(template.ID)