synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: time.NewTicker leaks (#4630)

Browse Source
This commit is contained in:
Colin Adler
2022-10-18 15:26:21 -05:00
committed by GitHub
parent 5d7d8c3a9a
commit 0a5e5544b1
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
agent/apphealth.go
View File

@ -60,8 +60,10 @@ func NewWorkspaceAppHealthReporter(logger slog.Logger, workspaceAgentApps Worksp
continue continue
} }
app := nextApp app := nextApp
t := time.NewTicker(time.Duration(app.Healthcheck.Interval) * time.Second)
go func() { go func() {
t := time.NewTicker(time.Duration(app.Healthcheck.Interval) * time.Second)
defer t.Stop()
for { for {
select { select {
case <-ctx.Done(): case <-ctx.Done():
@ -118,6 +120,7 @@ func NewWorkspaceAppHealthReporter(logger slog.Logger, workspaceAgentApps Worksp
lastHealth := copyHealth(health) lastHealth := copyHealth(health)
mu.Unlock() mu.Unlock()
reportTicker := time.NewTicker(time.Second) reportTicker := time.NewTicker(time.Second)
defer reportTicker.Stop()
// every second we check if the health values of the apps have changed // every second we check if the health values of the apps have changed
// and if there is a change we will report the new values. // and if there is a change we will report the new values.
for { for {

3
enterprise/derpmesh/derpmesh_test.go
View File

@ -74,6 +74,7 @@ func TestDERPMesh(t *testing.T) {
go func() { go func() {
defer close(closed) defer close(closed)
ticker := time.NewTicker(50 * time.Millisecond) ticker := time.NewTicker(50 * time.Millisecond)
defer ticker.Stop()
for { for {
select { select {
case <-ctx.Done(): case <-ctx.Done():
@ -118,6 +119,7 @@ func TestDERPMesh(t *testing.T) {
go func() { go func() {
defer close(closed) defer close(closed)
ticker := time.NewTicker(50 * time.Millisecond) ticker := time.NewTicker(50 * time.Millisecond)
defer ticker.Stop()
for { for {
select { select {
case <-ctx.Done(): case <-ctx.Done():
@ -169,6 +171,7 @@ func TestDERPMesh(t *testing.T) {
go func() { go func() {
defer close(closed) defer close(closed)
ticker := time.NewTicker(50 * time.Millisecond) ticker := time.NewTicker(50 * time.Millisecond)
defer ticker.Stop()
for { for {
select { select {
case <-ctx.Done(): case <-ctx.Done():