synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: refactor AgentHasNotConnectedSinceWeek_LogsExpired (#13802)

Browse Source
This commit is contained in:
Marcin Tojek
2024-07-08 13:52:56 +02:00
committed by GitHub
parent fecc5b3027
commit 10aa32ca08
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
coderd/database/dbpurge/dbpurge_test.go
View File

@ -11,6 +11,7 @@ import (
"time" "time"
"github.com/google/uuid" "github.com/google/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
"go.uber.org/goleak" "go.uber.org/goleak"
"golang.org/x/exp/slices" "golang.org/x/exp/slices"
@ -183,13 +184,20 @@ func TestDeleteOldWorkspaceAgentLogs(t *testing.T) {
// given // given
agent := mustCreateAgentWithLogs(ctx, t, db, user, org, tmpl, tv, now.Add(-8*24*time.Hour), t.Name()) agent := mustCreateAgentWithLogs(ctx, t, db, user, org, tmpl, tv, now.Add(-8*24*time.Hour), t.Name())
// Make sure that agent logs have been collected.
agentLogs, err := db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
AgentID: agent,
})
require.NoError(t, err)
require.NotZero(t, agentLogs, "agent logs must be present")
// when // when
closer := dbpurge.New(ctx, logger, db) closer := dbpurge.New(ctx, logger, db)
defer closer.Close() defer closer.Close()
// then // then
require.Eventually(t, func() bool { assert.Eventually(t, func() bool {
agentLogs, err := db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{ agentLogs, err = db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
AgentID: agent, AgentID: agent,
}) })
if err != nil { if err != nil {
@ -197,6 +205,8 @@ func TestDeleteOldWorkspaceAgentLogs(t *testing.T) {
} }
return !containsAgentLog(agentLogs, t.Name()) return !containsAgentLog(agentLogs, t.Name())
}, testutil.WaitShort, testutil.IntervalFast) }, testutil.WaitShort, testutil.IntervalFast)
require.NoError(t, err)
require.NotContains(t, agentLogs, t.Name())
}) })
t.Run("AgentConnectedSixDaysAgo_LogsValid", func(t *testing.T) { t.Run("AgentConnectedSixDaysAgo_LogsValid", func(t *testing.T) {