synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: update error message for duplicate organization members (#17594)

Browse Source 
Closes https://github.com/coder/internal/issues/345
This commit is contained in:
ケイラ
2025-04-28 13:51:33 -07:00
committed by GitHub
parent a78f0fc4e1
commit 12589026b6
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
coderd/members.go
View File

@ -62,7 +62,8 @@ func (api *API) postOrganizationMember(rw http.ResponseWriter, r *http.Request)
} }
if database.IsUniqueViolation(err, database.UniqueOrganizationMembersPkey) { if database.IsUniqueViolation(err, database.UniqueOrganizationMembersPkey) {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{ httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
Message: "Organization member already exists in this organization", Message: "User is already an organization member",
Detail: fmt.Sprintf("%s is already a member of %s", user.Username, organization.DisplayName),
}) })
return return
} }

2
coderd/members_test.go
View File

@ -26,7 +26,7 @@ func TestAddMember(t *testing.T) {
// Add user to org, even though they already exist // Add user to org, even though they already exist
// nolint:gocritic // must be an owner to see the user // nolint:gocritic // must be an owner to see the user
_, err := owner.PostOrganizationMember(ctx, first.OrganizationID, user.Username) _, err := owner.PostOrganizationMember(ctx, first.OrganizationID, user.Username)
require.ErrorContains(t, err, "already exists") require.ErrorContains(t, err, "already an organization member")
}) })
} }