From 12b51ca80431a97a66e2ca5c654dd2af852023b9 Mon Sep 17 00:00:00 2001 From: Ben Potter Date: Fri, 21 Jul 2023 07:22:54 -0500 Subject: [PATCH] ci: fix release notes compare link (#8581) Co-authored-by: Mathias Fredriksson --- .github/workflows/release.yaml | 2 +- scripts/release/generate_release_notes.sh | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 9139e25c4a..4b7f969183 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -76,7 +76,7 @@ jobs: set -euo pipefail ref=HEAD old_version="$(git describe --abbrev=0 "$ref^1")" - version="$(./scripts/version.sh)" + version="v$(./scripts/version.sh)" # Generate notes. release_notes_file="$(mktemp -t release_notes.XXXXXX)" diff --git a/scripts/release/generate_release_notes.sh b/scripts/release/generate_release_notes.sh index cb2f37bb09..aea595459d 100755 --- a/scripts/release/generate_release_notes.sh +++ b/scripts/release/generate_release_notes.sh @@ -54,6 +54,9 @@ fi if [[ -z $new_version ]]; then error "No new version specified" fi +if [[ $new_version != v* ]]; then + error "New version must start with a v" +fi if [[ -z $ref ]]; then error "No ref specified" fi