synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-23 21:32:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(coderd): fix test flake with auditor (#11316)

Browse Source
This commit is contained in:
Cian Johnston
2023-12-22 09:50:49 +00:00
committed by GitHub
parent 167c15238a
commit 19abde12fb
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
coderd/workspacebuilds_test.go
View File

@@ -51,9 +51,12 @@ func TestWorkspaceBuild(t *testing.T) {
_ = coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, workspace.LatestBuild.ID) _ = coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, workspace.LatestBuild.ID)
// Create workspace will also start a build, so we need to wait for // Create workspace will also start a build, so we need to wait for
// it to ensure all events are recorded. // it to ensure all events are recorded.
require.Len(t, auditor.AuditLogs(), 2) require.Eventually(t, func() bool {
require.Equal(t, auditor.AuditLogs()[0].Ip.IPNet.IP.String(), "127.0.0.1") logs := auditor.AuditLogs()
require.Equal(t, auditor.AuditLogs()[1].Ip.IPNet.IP.String(), "127.0.0.1") return len(logs) == 2 &&
assert.Equal(t, logs[0].Ip.IPNet.IP.String(), "127.0.0.1") &&
assert.Equal(t, logs[1].Ip.IPNet.IP.String(), "127.0.0.1")
}, testutil.WaitShort, testutil.IntervalFast)
} }
func TestWorkspaceBuildByBuildNumber(t *testing.T) { func TestWorkspaceBuildByBuildNumber(t *testing.T) {
@@ -969,8 +972,11 @@ func TestPostWorkspaceBuild(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, build.ID) coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, build.ID)
require.Len(t, auditor.AuditLogs(), 1) require.Eventually(t, func() bool {
require.Equal(t, auditor.AuditLogs()[0].Ip.IPNet.IP.String(), "127.0.0.1") logs := auditor.AuditLogs()
return len(logs) > 0 &&
assert.Equal(t, logs[0].Ip.IPNet.IP.String(), "127.0.0.1")
}, testutil.WaitShort, testutil.IntervalFast)
}) })
t.Run("IncrementBuildNumber", func(t *testing.T) { t.Run("IncrementBuildNumber", func(t *testing.T) {