synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-08 11:39:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(coderd/prometheusmetrics): close batcher to force flush before asserting agent stats (#9465)

Browse Source
This commit is contained in:
Cian Johnston
2023-08-31 11:40:57 +01:00
committed by GitHub
parent fd17857095
commit 22f31e721c
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
coderd/prometheusmetrics/prometheusmetrics_test.go
View File

@ -379,13 +379,15 @@ func TestAgentStats(t *testing.T) {
t.Cleanup(cancelFunc)
db, pubsub := dbtestutil.NewDB(t)
log := slogtest.Make(t, nil)
log := slogtest.Make(t, nil).Leveled(slog.LevelDebug)
batcher, closeBatcher, err := batchstats.New(ctx,
// We had previously set the batch size to 1 here, but that caused
// intermittent test flakes due to a race between the batcher completing
// its flush and the test asserting that the metrics were collected.
// Instead, we close the batcher after all stats have been posted, which
// forces a flush.
batchstats.WithStore(db),
// We want our stats, and we want them NOW.
batchstats.WithBatchSize(1),
batchstats.WithInterval(time.Hour),
batchstats.WithLogger(log),
)
require.NoError(t, err, "create stats batcher failed")
@ -435,6 +437,11 @@ func TestAgentStats(t *testing.T) {
require.NoError(t, err)
}
// Ensure that all stats are flushed to the database
// before we query them. We do not expect any more stats
// to be posted after this.
closeBatcher()
// when
//
// Set initialCreateAfter to some time in the past, so that AgentStats would include all above PostStats,