synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-12 00:14:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove AwaitWorkspaceAgents in goroutines

Browse Source 
AwaitWorkspaceAgent calls testify.require which isn't allowed from a goroutine and causes cascading failures in the test suite such as: https://github.com/coder/coder/actions/runs/6458768855/job/17533163316

I don't believe these functions serve a direct purpose since nothing else is "waiting" for the functions to return before doing other things.
This commit is contained in:
Spike Curtis
2023-10-09 20:37:23 +04:00
committed by GitHub
parent 17e889af16
commit 24c80bf532
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cli/ssh_test.go
View File

@ -183,7 +183,6 @@ func TestSSH(t *testing.T) {
// Run this async so the SSH command has to wait for // Run this async so the SSH command has to wait for
// the build and agent to connect! // the build and agent to connect!
_ = agenttest.New(t, client.URL, agentToken) _ = agenttest.New(t, client.URL, agentToken)
coderdtest.AwaitWorkspaceAgents(t, client, workspace.ID)
<-ctx.Done() <-ctx.Done()
}) })
@ -246,7 +245,6 @@ func TestSSH(t *testing.T) {
// Run this async so the SSH command has to wait for // Run this async so the SSH command has to wait for
// the build and agent to connect. // the build and agent to connect.
_ = agenttest.New(t, client.URL, agentToken) _ = agenttest.New(t, client.URL, agentToken)
coderdtest.AwaitWorkspaceAgents(t, client, workspace.ID)
<-ctx.Done() <-ctx.Done()
}) })