synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-03 16:13:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: improve postgres test time by removing cleanup (#7522)

Browse Source 
We don't need to delete databases on cleanup... and we don't need to
always run without a cache either!
This commit is contained in:
Kyle Carberry
2023-05-14 15:32:44 -05:00
committed by GitHub
parent 778cb7494a
commit 26490aecca
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
coderd/database/postgres/postgres.go
View File

@ -46,13 +46,10 @@ func Open() (string, func(), error) {
return "", nil, xerrors.Errorf("create db with template: %w", err)
}
deleteDB := func() {
ddb, _ := sql.Open("postgres", dbURL)
defer ddb.Close()
_, _ = ddb.Exec("DROP DATABASE " + dbName)
}
return "postgres://postgres:postgres@127.0.0.1:5432/" + dbName + "?sslmode=disable", deleteDB, nil
return "postgres://postgres:postgres@127.0.0.1:5432/" + dbName + "?sslmode=disable", func() {
// We don't need to clean anything up here... it's just a database in a container,
// so cleaning up the container will clean up the database.
}, nil
}
pool, err := dockertest.NewPool("")