synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-08 11:39:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Add custom version names (#4186)

Browse Source 
Fixes #4137.
This commit is contained in:
Kyle Carberry
2022-09-23 20:17:36 -05:00
committed by GitHub
parent 3c215a83b6
commit 28428d1294
7 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
coderd/templateversions.go
View File

@ -791,13 +791,17 @@ func (api *API) postTemplateVersionsByOrganization(rw http.ResponseWriter, r *ht
}
}
if req.Name == "" {
req.Name = namesgenerator.GetRandomName(1)
}
templateVersion, err = db.InsertTemplateVersion(ctx, database.InsertTemplateVersionParams{
ID: uuid.New(),
TemplateID: templateID,
OrganizationID: organization.ID,
CreatedAt: database.Now(),
UpdatedAt: database.Now(),
Name: namesgenerator.GetRandomName(1),
Name: req.Name,
Readme: "",
JobID: provisionerJob.ID,
CreatedBy: uuid.NullUUID{

4
coderd/templateversions_test.go
View File

@ -93,7 +93,8 @@ func TestPostTemplateVersionsByOrganization(t *testing.T) {
file, err := client.Upload(ctx, codersdk.ContentTypeTar, data)
require.NoError(t, err)
_, err = client.CreateTemplateVersion(ctx, user.OrganizationID, codersdk.CreateTemplateVersionRequest{
version, err := client.CreateTemplateVersion(ctx, user.OrganizationID, codersdk.CreateTemplateVersionRequest{
Name: "bananas",
StorageMethod: codersdk.ProvisionerStorageMethodFile,
StorageSource: file.Hash,
Provisioner: codersdk.ProvisionerTypeEcho,
@ -105,6 +106,7 @@ func TestPostTemplateVersionsByOrganization(t *testing.T) {
}},
})
require.NoError(t, err)
require.Equal(t, "bananas", version.Name)
require.Len(t, auditor.AuditLogs, 1)
assert.Equal(t, database.AuditActionCreate, auditor.AuditLogs[0].Action)