From 34752fa1485c79b5cef6ba420f22461b1e64a336 Mon Sep 17 00:00:00 2001 From: Edward Angert Date: Mon, 14 Apr 2025 08:03:25 -0400 Subject: [PATCH] docs: add note about sign in with GitHub button should be hidden when flow is disabled (#17367) Co-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com> --- docs/admin/users/github-auth.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/admin/users/github-auth.md b/docs/admin/users/github-auth.md index d895764c44..c556c87a2a 100644 --- a/docs/admin/users/github-auth.md +++ b/docs/admin/users/github-auth.md @@ -41,6 +41,14 @@ own app or set: CODER_OAUTH2_GITHUB_DEFAULT_PROVIDER_ENABLE=false ``` +> [!NOTE] +> After you disable the default GitHub provider with the setting above, the +> **Sign in with GitHub** button might still appear on your login page even though +> the authentication flow is disabled. +> +> To completely hide the GitHub sign-in button, you must both disable the default +> provider and ensure you don't have a custom GitHub OAuth app configured. + ## Step 1: Configure the OAuth application in GitHub First,