synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-09 11:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: healthcheck warnings should be empty array (#10856)

Browse Source
This commit is contained in:
Marcin Tojek
2023-11-24 12:37:07 +01:00
committed by GitHub
parent 2c6e0f7d0a
commit 34841cf2b7
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
coderd/healthcheck/derphealth/derp.go
View File

@ -166,6 +166,7 @@ func (r *RegionReport) Run(ctx context.Context) {
r.Healthy = true r.Healthy = true
r.Severity = health.SeverityOK r.Severity = health.SeverityOK
r.NodeReports = []*NodeReport{} r.NodeReports = []*NodeReport{}
r.Warnings = []string{}
wg := &sync.WaitGroup{} wg := &sync.WaitGroup{}
var unhealthyNodes int // atomic.Int64 is not mandatory as we depend on RegionReport mutex. var unhealthyNodes int // atomic.Int64 is not mandatory as we depend on RegionReport mutex.
@ -262,6 +263,7 @@ func (r *NodeReport) Run(ctx context.Context) {
r.Severity = health.SeverityOK r.Severity = health.SeverityOK
r.ClientLogs = [][]string{} r.ClientLogs = [][]string{}
r.ClientErrs = [][]string{} r.ClientErrs = [][]string{}
r.Warnings = []string{}
wg := &sync.WaitGroup{} wg := &sync.WaitGroup{}

4
coderd/healthcheck/derphealth/derp_test.go
View File

@ -68,6 +68,8 @@ func TestDERP(t *testing.T) {
for _, node := range region.NodeReports { for _, node := range region.NodeReports {
assert.True(t, node.Healthy) assert.True(t, node.Healthy)
assert.True(t, node.CanExchangeMessages) assert.True(t, node.CanExchangeMessages)
assert.Empty(t, node.Warnings)
assert.NotNil(t, node.Warnings)
assert.NotEmpty(t, node.RoundTripPing) assert.NotEmpty(t, node.RoundTripPing)
assert.Len(t, node.ClientLogs, 2) assert.Len(t, node.ClientLogs, 2)
assert.Len(t, node.ClientLogs[0], 3) assert.Len(t, node.ClientLogs[0], 3)
@ -128,6 +130,8 @@ func TestDERP(t *testing.T) {
for _, region := range report.Regions { for _, region := range report.Regions {
assert.True(t, region.Healthy) assert.True(t, region.Healthy)
assert.True(t, region.NodeReports[0].Healthy) assert.True(t, region.NodeReports[0].Healthy)
assert.Empty(t, region.NodeReports[0].Warnings)
assert.NotNil(t, region.NodeReports[0].Warnings)
assert.Equal(t, health.SeverityOK, region.NodeReports[0].Severity) assert.Equal(t, health.SeverityOK, region.NodeReports[0].Severity)
assert.False(t, region.NodeReports[1].Healthy) assert.False(t, region.NodeReports[1].Healthy)
assert.Equal(t, health.SeverityError, region.NodeReports[1].Severity) assert.Equal(t, health.SeverityError, region.NodeReports[1].Severity)