mirror of
https://github.com/coder/coder.git
synced 2025-07-09 11:45:56 +00:00
fix: healthcheck warnings should be empty array (#10856)
This commit is contained in:
@ -166,6 +166,7 @@ func (r *RegionReport) Run(ctx context.Context) {
|
|||||||
r.Healthy = true
|
r.Healthy = true
|
||||||
r.Severity = health.SeverityOK
|
r.Severity = health.SeverityOK
|
||||||
r.NodeReports = []*NodeReport{}
|
r.NodeReports = []*NodeReport{}
|
||||||
|
r.Warnings = []string{}
|
||||||
|
|
||||||
wg := &sync.WaitGroup{}
|
wg := &sync.WaitGroup{}
|
||||||
var unhealthyNodes int // atomic.Int64 is not mandatory as we depend on RegionReport mutex.
|
var unhealthyNodes int // atomic.Int64 is not mandatory as we depend on RegionReport mutex.
|
||||||
@ -262,6 +263,7 @@ func (r *NodeReport) Run(ctx context.Context) {
|
|||||||
r.Severity = health.SeverityOK
|
r.Severity = health.SeverityOK
|
||||||
r.ClientLogs = [][]string{}
|
r.ClientLogs = [][]string{}
|
||||||
r.ClientErrs = [][]string{}
|
r.ClientErrs = [][]string{}
|
||||||
|
r.Warnings = []string{}
|
||||||
|
|
||||||
wg := &sync.WaitGroup{}
|
wg := &sync.WaitGroup{}
|
||||||
|
|
||||||
|
@ -68,6 +68,8 @@ func TestDERP(t *testing.T) {
|
|||||||
for _, node := range region.NodeReports {
|
for _, node := range region.NodeReports {
|
||||||
assert.True(t, node.Healthy)
|
assert.True(t, node.Healthy)
|
||||||
assert.True(t, node.CanExchangeMessages)
|
assert.True(t, node.CanExchangeMessages)
|
||||||
|
assert.Empty(t, node.Warnings)
|
||||||
|
assert.NotNil(t, node.Warnings)
|
||||||
assert.NotEmpty(t, node.RoundTripPing)
|
assert.NotEmpty(t, node.RoundTripPing)
|
||||||
assert.Len(t, node.ClientLogs, 2)
|
assert.Len(t, node.ClientLogs, 2)
|
||||||
assert.Len(t, node.ClientLogs[0], 3)
|
assert.Len(t, node.ClientLogs[0], 3)
|
||||||
@ -128,6 +130,8 @@ func TestDERP(t *testing.T) {
|
|||||||
for _, region := range report.Regions {
|
for _, region := range report.Regions {
|
||||||
assert.True(t, region.Healthy)
|
assert.True(t, region.Healthy)
|
||||||
assert.True(t, region.NodeReports[0].Healthy)
|
assert.True(t, region.NodeReports[0].Healthy)
|
||||||
|
assert.Empty(t, region.NodeReports[0].Warnings)
|
||||||
|
assert.NotNil(t, region.NodeReports[0].Warnings)
|
||||||
assert.Equal(t, health.SeverityOK, region.NodeReports[0].Severity)
|
assert.Equal(t, health.SeverityOK, region.NodeReports[0].Severity)
|
||||||
assert.False(t, region.NodeReports[1].Healthy)
|
assert.False(t, region.NodeReports[1].Healthy)
|
||||||
assert.Equal(t, health.SeverityError, region.NodeReports[1].Severity)
|
assert.Equal(t, health.SeverityError, region.NodeReports[1].Severity)
|
||||||
|
Reference in New Issue
Block a user