synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): scaletest: ignore errors syncing output (#13076)

Browse Source
This commit is contained in:
Cian Johnston
2024-04-26 09:18:33 +01:00
committed by GitHub
parent 74f27719b8
commit 365231b1e5
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cli/exp_scaletest.go
View File

@ -14,7 +14,6 @@ import (
"strconv" "strconv"
"strings" "strings"
"sync" "sync"
"syscall"
"time" "time"
"github.com/google/uuid" "github.com/google/uuid"
@ -245,14 +244,8 @@ func (o *scaleTestOutput) write(res harness.Results, stdout io.Writer) error {
// Sync the file to disk if it's a file. // Sync the file to disk if it's a file.
if s, ok := w.(interface{ Sync() error }); ok { if s, ok := w.(interface{ Sync() error }); ok {
err := s.Sync() // Best effort. If we get an error from syncing, just ignore it.
// On Linux, EINVAL is returned when calling fsync on /dev/stdout. We _ = s.Sync()
// can safely ignore this error.
// On macOS, ENOTTY is returned when calling sync on /dev/stdout. We
// can safely ignore this error.
if err != nil && !xerrors.Is(err, syscall.EINVAL) && !xerrors.Is(err, syscall.ENOTTY) {
return xerrors.Errorf("flush output file: %w", err)
}
} }
if c != nil { if c != nil {