From 385a4262e2f572fd231f63ccd3ef63bd87d85ee7 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Tue, 4 Apr 2023 12:11:10 -0500 Subject: [PATCH] fix: remove audit-logging flag from the server (#6991) Co-authored-by: Colin Adler --- cli/testdata/coder_server_--help.golden | 3 --- coderd/apidoc/docs.go | 3 --- coderd/apidoc/swagger.json | 3 --- codersdk/deployment.go | 11 ----------- docs/api/general.md | 1 - docs/api/schemas.md | 3 --- docs/cli/server.md | 10 ---------- enterprise/cli/server.go | 13 +++++-------- site/src/api/typesGenerated.ts | 1 - 9 files changed, 5 insertions(+), 43 deletions(-) diff --git a/cli/testdata/coder_server_--help.golden b/cli/testdata/coder_server_--help.golden index 56edb2c58d..f40f5ac07c 100644 --- a/cli/testdata/coder_server_--help.golden +++ b/cli/testdata/coder_server_--help.golden @@ -353,9 +353,6 @@ telemetrywhen required by your organization's security policy. Enterprise Options These options are only available in the Enterprise Edition. - --audit-logging bool, $CODER_AUDIT_LOGGING (default: true) - Specifies whether audit logging is enabled. - --browser-only bool, $CODER_BROWSER_ONLY Whether Coder only allows connections to workspaces via the browser. diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go index c6ef971f88..f495d71e1d 100644 --- a/coderd/apidoc/docs.go +++ b/coderd/apidoc/docs.go @@ -6894,9 +6894,6 @@ const docTemplate = `{ "agent_stat_refresh_interval": { "type": "integer" }, - "audit_logging": { - "type": "boolean" - }, "autobuild_poll_interval": { "type": "integer" }, diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json index 750563cc9c..785db2ebbe 100644 --- a/coderd/apidoc/swagger.json +++ b/coderd/apidoc/swagger.json @@ -6158,9 +6158,6 @@ "agent_stat_refresh_interval": { "type": "integer" }, - "audit_logging": { - "type": "boolean" - }, "autobuild_poll_interval": { "type": "integer" }, diff --git a/codersdk/deployment.go b/codersdk/deployment.go index ebace34887..3247ad194d 100644 --- a/codersdk/deployment.go +++ b/codersdk/deployment.go @@ -142,7 +142,6 @@ type DeploymentValues struct { MetricsCacheRefreshInterval clibase.Duration `json:"metrics_cache_refresh_interval,omitempty" typescript:",notnull"` AgentStatRefreshInterval clibase.Duration `json:"agent_stat_refresh_interval,omitempty" typescript:",notnull"` AgentFallbackTroubleshootingURL clibase.URL `json:"agent_fallback_troubleshooting_url,omitempty" typescript:",notnull"` - AuditLogging clibase.Bool `json:"audit_logging,omitempty" typescript:",notnull"` BrowserOnly clibase.Bool `json:"browser_only,omitempty" typescript:",notnull"` SCIMAPIKey clibase.String `json:"scim_api_key,omitempty" typescript:",notnull"` Provisioner ProvisionerConfig `json:"provisioner,omitempty" typescript:",notnull"` @@ -1262,16 +1261,6 @@ when required by your organization's security policy.`, Value: &c.AgentFallbackTroubleshootingURL, YAML: "agentFallbackTroubleshootingURL", }, - { - Name: "Audit Logging", - Description: "Specifies whether audit logging is enabled.", - Flag: "audit-logging", - Env: "CODER_AUDIT_LOGGING", - Default: "true", - Annotations: clibase.Annotations{}.Mark(flagEnterpriseKey, "true"), - Value: &c.AuditLogging, - YAML: "auditLogging", - }, { Name: "Browser Only", Description: "Whether Coder only allows connections to workspaces via the browser.", diff --git a/docs/api/general.md b/docs/api/general.md index 43dafb41e5..4a264d9d1b 100644 --- a/docs/api/general.md +++ b/docs/api/general.md @@ -150,7 +150,6 @@ curl -X GET http://coder-server:8080/api/v2/deployment/config \ "user": {} }, "agent_stat_refresh_interval": 0, - "audit_logging": true, "autobuild_poll_interval": 0, "browser_only": true, "cache_directory": "string", diff --git a/docs/api/schemas.md b/docs/api/schemas.md index 54facac87e..8c934d4e06 100644 --- a/docs/api/schemas.md +++ b/docs/api/schemas.md @@ -1754,7 +1754,6 @@ CreateParameterRequest is a structure used to create a new parameter value for a "user": {} }, "agent_stat_refresh_interval": 0, - "audit_logging": true, "autobuild_poll_interval": 0, "browser_only": true, "cache_directory": "string", @@ -2102,7 +2101,6 @@ CreateParameterRequest is a structure used to create a new parameter value for a "user": {} }, "agent_stat_refresh_interval": 0, - "audit_logging": true, "autobuild_poll_interval": 0, "browser_only": true, "cache_directory": "string", @@ -2321,7 +2319,6 @@ CreateParameterRequest is a structure used to create a new parameter value for a | `address` | [clibase.HostPort](#clibasehostport) | false | | Address Use HTTPAddress or TLS.Address instead. | | `agent_fallback_troubleshooting_url` | [clibase.URL](#clibaseurl) | false | | | | `agent_stat_refresh_interval` | integer | false | | | -| `audit_logging` | boolean | false | | | | `autobuild_poll_interval` | integer | false | | | | `browser_only` | boolean | false | | | | `cache_directory` | string | false | | | diff --git a/docs/cli/server.md b/docs/cli/server.md index e9c9e73bb6..a2ffbbbd0e 100644 --- a/docs/cli/server.md +++ b/docs/cli/server.md @@ -29,16 +29,6 @@ coder server [flags] The URL that users will use to access the Coder deployment. -### --audit-logging - -| | | -| ----------- | --------------------------------- | -| Type | bool | -| Environment | $CODER_AUDIT_LOGGING | -| Default | true | - -Specifies whether audit logging is enabled. - ### --browser-only | | | diff --git a/enterprise/cli/server.go b/enterprise/cli/server.go index 68b78648e6..d26f9e1b64 100644 --- a/enterprise/cli/server.go +++ b/enterprise/cli/server.go @@ -49,18 +49,15 @@ func (r *RootCmd) server() *clibase.Cmd { } } options.DERPServer.SetMeshKey(meshKey) - - if options.DeploymentValues.AuditLogging.Value() { - options.Auditor = audit.NewAuditor(audit.DefaultFilter, - backends.NewPostgres(options.Database, true), - backends.NewSlog(options.Logger), - ) - } + options.Auditor = audit.NewAuditor(audit.DefaultFilter, + backends.NewPostgres(options.Database, true), + backends.NewSlog(options.Logger), + ) options.TrialGenerator = trialer.New(options.Database, "https://v2-licensor.coder.com/trial", coderd.Keys) o := &coderd.Options{ - AuditLogging: options.DeploymentValues.AuditLogging.Value(), + AuditLogging: true, BrowserOnly: options.DeploymentValues.BrowserOnly.Value(), SCIMAPIKey: []byte(options.DeploymentValues.SCIMAPIKey.Value()), RBAC: true, diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts index 41bd312808..a546718b9b 100644 --- a/site/src/api/typesGenerated.ts +++ b/site/src/api/typesGenerated.ts @@ -349,7 +349,6 @@ export interface DeploymentValues { readonly metrics_cache_refresh_interval?: number readonly agent_stat_refresh_interval?: number readonly agent_fallback_troubleshooting_url?: string - readonly audit_logging?: boolean readonly browser_only?: boolean readonly scim_api_key?: string readonly provisioner?: ProvisionerConfig