synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-09 11:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: convert dbfake.ProvisionerJobResources to builder (#10881)

Browse Source 
Convert to builder for consistency with rest of the package.  This will make it easier to use, and means we can drop "Builder" from function arguments since they are all builders in the package.
This commit is contained in:
Spike Curtis
2023-11-27 14:46:31 +04:00
committed by GitHub
parent 4548ad7cef
commit 3a0a4ddfcd
1 changed files with 29 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
coderd/database/dbfake/dbfake.go
View File

@ -187,11 +187,11 @@ func (b WorkspaceBuildBuilder) Do() database.WorkspaceBuild {
Valid: true, Valid: true,
}, },
}) })
ProvisionerJobResources(b.t, b.db, jobID, b.seed.Transition, b.resources...) NewProvisionerJobResourcesBuilder(b.t, b.db, jobID, b.seed.Transition, b.resources...).Do()
b.seed.TemplateVersionID = templateVersion.ID b.seed.TemplateVersionID = templateVersion.ID
} }
build := dbgen.WorkspaceBuild(b.t, b.db, b.seed) build := dbgen.WorkspaceBuild(b.t, b.db, b.seed)
ProvisionerJobResources(b.t, b.db, job.ID, b.seed.Transition, b.resources...) NewProvisionerJobResourcesBuilder(b.t, b.db, job.ID, b.seed.Transition, b.resources...).Do()
if b.ps != nil { if b.ps != nil {
err = b.ps.Publish(codersdk.WorkspaceNotifyChannel(build.WorkspaceID), []byte{}) err = b.ps.Publish(codersdk.WorkspaceNotifyChannel(build.WorkspaceID), []byte{})
require.NoError(b.t, err) require.NoError(b.t, err)
@ -199,16 +199,37 @@ func (b WorkspaceBuildBuilder) Do() database.WorkspaceBuild {
return build return build
} }
// ProvisionerJobResources inserts a series of resources into a provisioner job. type ProvisionerJobResourcesBuilder struct {
func ProvisionerJobResources(t testing.TB, db database.Store, job uuid.UUID, transition database.WorkspaceTransition, resources ...*sdkproto.Resource) { t testing.TB
t.Helper() db database.Store
jobID uuid.UUID
transition database.WorkspaceTransition
resources []*sdkproto.Resource
}
// NewProvisionerJobResourcesBuilder inserts a series of resources into a provisioner job.
func NewProvisionerJobResourcesBuilder(
t testing.TB, db database.Store, jobID uuid.UUID, transition database.WorkspaceTransition, resources ...*sdkproto.Resource,
) ProvisionerJobResourcesBuilder {
return ProvisionerJobResourcesBuilder{
t: t,
db: db,
jobID: jobID,
transition: transition,
resources: resources,
}
}
func (b ProvisionerJobResourcesBuilder) Do() {
b.t.Helper()
transition := b.transition
if transition == "" { if transition == "" {
// Default to start! // Default to start!
transition = database.WorkspaceTransitionStart transition = database.WorkspaceTransitionStart
} }
for _, resource := range resources { for _, resource := range b.resources {
//nolint:gocritic // This is only used by tests. //nolint:gocritic // This is only used by tests.
err := provisionerdserver.InsertWorkspaceResource(dbauthz.AsSystemRestricted(context.Background()), db, job, transition, resource, &telemetry.Snapshot{}) err := provisionerdserver.InsertWorkspaceResource(dbauthz.AsSystemRestricted(context.Background()), b.db, b.jobID, transition, resource, &telemetry.Snapshot{})
require.NoError(t, err) require.NoError(b.t, err)
} }
} }