synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-15 22:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: test: do not block Prometheus port (#13945)

Browse Source
This commit is contained in:
Marcin Tojek
2024-07-19 16:29:10 +02:00
committed by GitHub
parent c88e4162d8
commit 40609c26e9
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
enterprise/cli/provisionerdaemons_test.go
View File

@ -303,7 +303,7 @@ func TestProvisionerDaemon_SessionToken(t *testing.T) {
t.Run("PrometheusEnabled", func(t *testing.T) { t.Run("PrometheusEnabled", func(t *testing.T) {
t.Parallel() t.Parallel()
prometheusPort := testutil.RandomPort(t) prometheusPort := testutil.RandomPortNoListen(t)
// Configure CLI client // Configure CLI client
client, admin := coderdenttest.New(t, &coderdenttest.Options{ client, admin := coderdenttest.New(t, &coderdenttest.Options{
@ -333,18 +333,27 @@ func TestProvisionerDaemon_SessionToken(t *testing.T) {
return false return false
} }
return len(daemons) == 1 return len(daemons) == 1
}, testutil.WaitShort, testutil.IntervalSlow) }, testutil.WaitLong, testutil.IntervalSlow)
require.Equal(t, "daemon-with-prometheus", daemons[0].Name) require.Equal(t, "daemon-with-prometheus", daemons[0].Name)
// Fetch metrics from Prometheus endpoint // Fetch metrics from Prometheus endpoint
var req *http.Request
var res *http.Response var res *http.Response
require.Eventually(t, func() bool { require.Eventually(t, func() bool {
req, err := http.NewRequestWithContext(ctx, "GET", fmt.Sprintf("http://127.0.0.1:%d", prometheusPort), nil) req, err = http.NewRequestWithContext(ctx, "GET", fmt.Sprintf("http://127.0.0.1:%d", prometheusPort), nil)
assert.NoError(t, err) if err != nil {
t.Logf("unable to create new HTTP request: %s", err.Error())
return false
}
// nolint:bodyclose // nolint:bodyclose
res, err = http.DefaultClient.Do(req) res, err = http.DefaultClient.Do(req)
return err == nil if err != nil {
}, testutil.WaitShort, testutil.IntervalFast) t.Logf("unable to call Prometheus endpoint: %s", err.Error())
return false
}
return true
}, testutil.WaitShort, testutil.IntervalMedium)
defer res.Body.Close() defer res.Body.Close()
// Scan for metric patterns // Scan for metric patterns