diff --git a/enterprise/coderd/prebuilds/claim_test.go b/enterprise/coderd/prebuilds/claim_test.go index 6ce304ba38..f257b1efb7 100644 --- a/enterprise/coderd/prebuilds/claim_test.go +++ b/enterprise/coderd/prebuilds/claim_test.go @@ -104,7 +104,7 @@ func TestClaimPrebuild(t *testing.T) { ctx = dbauthz.AsSystemRestricted(ctx) // Given: a reconciliation completes. - controller.Reconcile(ctx, nil) + require.NoError(t, controller.ReconcileAll(ctx)) // Given: a set of running, eligible prebuilds eventually starts up. runningPrebuilds := make(map[uuid.UUID]database.GetRunningPrebuildsRow, desiredInstances*presetCount) diff --git a/enterprise/coderd/prebuilds/controller_test.go b/enterprise/coderd/prebuilds/controller_test.go index b32c33ca7d..0b699c7cd1 100644 --- a/enterprise/coderd/prebuilds/controller_test.go +++ b/enterprise/coderd/prebuilds/controller_test.go @@ -53,7 +53,7 @@ func TestNoReconciliationActionsIfNoPresets(t *testing.T) { require.Equal(t, templateVersion, gotTemplateVersion) // when we trigger the reconciliation loop for all templates - controller.Reconcile(ctx, nil) + require.NoError(t, controller.ReconcileAll(ctx)) // then no reconciliation actions are taken // because without presets, there are no prebuilds @@ -109,7 +109,7 @@ func TestNoReconciliationActionsIfNoPrebuilds(t *testing.T) { require.NotEmpty(t, presetParameters) // when we trigger the reconciliation loop for all templates - controller.Reconcile(ctx, nil) + require.NoError(t, controller.ReconcileAll(ctx)) // then no reconciliation actions are taken // because without prebuilds, there is nothing to reconcile @@ -316,7 +316,7 @@ func TestActiveTemplateVersionPrebuilds(t *testing.T) { templateID, ) - controller.Reconcile(ctx, nil) + require.NoError(t, controller.ReconcileAll(ctx)) createdNewPrebuild := false deletedOldPrebuild := true @@ -365,7 +365,7 @@ func TestInactiveTemplateVersionPrebuilds(t *testing.T) { // * a third is not running because its latest build was a start transition but the build failed // * a fourth is not running because its latest build was a start transition but the build was canceled // when we trigger the reconciliation loop for all templates - controller.Reconcile(ctx, nil) + require.NoError(t, controller.ReconcileAll(ctx)) // then the four non running prebuilds are deleted // and 1 of the running prebuilds is deleted // because stopped, deleted and failed builds are not considered running in terms of the definition of "running" above.