mirror of
https://github.com/coder/coder.git
synced 2025-07-15 22:20:27 +00:00
chore: reduce log volume on server startup (#16608)
Addresses https://github.com/coder/coder/issues/16231. This PR reduces the volume of logs we print after server startup in order to surface the web UI URL better. Here are the logs after the changes a couple of seconds after starting the server: <img width="868" alt="Screenshot 2025-02-18 at 16 31 32" src="https://github.com/user-attachments/assets/786dc4b8-7383-48c8-a5c3-a997c01ca915" /> The warning is due to running a development site-less build. It wouldn't show in a release build.
This commit is contained in:
@ -54,7 +54,6 @@ func Test_absoluteBinaryPath(t *testing.T) {
|
||||
t.Skip("Dummy terraform executable on Windows requires sh which isn't very practical.")
|
||||
}
|
||||
|
||||
log := testutil.Logger(t)
|
||||
// Create a temp dir with the binary
|
||||
tempDir := t.TempDir()
|
||||
terraformBinaryOutput := fmt.Sprintf(`#!/bin/sh
|
||||
@ -85,11 +84,12 @@ func Test_absoluteBinaryPath(t *testing.T) {
|
||||
}
|
||||
|
||||
ctx := testutil.Context(t, testutil.WaitShort)
|
||||
actualAbsoluteBinary, actualErr := absoluteBinaryPath(ctx, log)
|
||||
actualBinaryDetails, actualErr := systemBinary(ctx)
|
||||
|
||||
require.Equal(t, expectedAbsoluteBinary, actualAbsoluteBinary)
|
||||
if tt.expectedErr == nil {
|
||||
require.NoError(t, actualErr)
|
||||
require.Equal(t, expectedAbsoluteBinary, actualBinaryDetails.absolutePath)
|
||||
require.Equal(t, tt.terraformVersion, actualBinaryDetails.version.String())
|
||||
} else {
|
||||
require.EqualError(t, actualErr, tt.expectedErr.Error())
|
||||
}
|
||||
|
Reference in New Issue
Block a user