synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-15 22:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: add webhook tests for notification subsystem (#13942)

Browse Source
This commit is contained in:
Danny Kopping
2024-07-19 12:03:29 +02:00
committed by GitHub
parent 943ea7c52a
commit 492ab1cc7e
2 changed files with 153 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
coderd/notifications/dispatch/webhook.go
View File

@ -78,11 +78,16 @@ func (w *WebhookHandler) dispatch(msgPayload types.MessagePayload, title, body,
return false, xerrors.Errorf("create HTTP request: %v", err)
}
req.Header.Set("Content-Type", "application/json")
req.Header.Set("X-Message-Id", msgID.String())
// Send request.
resp, err := w.cl.Do(req)
if err != nil {
return true, xerrors.Errorf("failed to send HTTP request: %v", err)
if errors.Is(err, context.DeadlineExceeded) {
return true, xerrors.Errorf("request timeout: %w", err)
}
return true, xerrors.Errorf("request failed: %w", err)
}
defer resp.Body.Close()
@ -93,11 +98,11 @@ func (w *WebhookHandler) dispatch(msgPayload types.MessagePayload, title, body,
lr := io.LimitReader(resp.Body, int64(len(respBody)))
n, err := lr.Read(respBody)
if err != nil && !errors.Is(err, io.EOF) {
return true, xerrors.Errorf("non-200 response (%d), read body: %w", resp.StatusCode, err)
return true, xerrors.Errorf("non-2xx response (%d), read body: %w", resp.StatusCode, err)
}
w.log.Warn(ctx, "unsuccessful delivery", slog.F("status_code", resp.StatusCode),
slog.F("response", respBody[:n]), slog.F("msg_id", msgID))
return true, xerrors.Errorf("non-200 response (%d)", resp.StatusCode)
return true, xerrors.Errorf("non-2xx response (%d)", resp.StatusCode)
}
return false, nil