synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-08 11:39:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: make build table show empty instead of loading when none are recent (#5666)

Browse Source 
* Fix builds to show empty instead of loading

* Switch to backend fix

* Increase e2e test timeout

* Format
This commit is contained in:
Presley Pizzo
2023-01-11 12:18:06 -05:00
committed by GitHub
parent a5d39adf3e
commit 627fbe5874
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
coderd/workspacebuilds.go
View File

@ -907,7 +907,8 @@ func (api *API) convertWorkspaceBuilds(
templateVersionByID[templateVersion.ID] = templateVersion
}
var apiBuilds []codersdk.WorkspaceBuild
// Should never be nil for API consistency
apiBuilds := []codersdk.WorkspaceBuild{}
for _, build := range workspaceBuilds {
job, exists := jobByID[build.JobID]
if !exists {

2
coderd/workspacebuilds_test.go
View File

@ -171,6 +171,8 @@ func TestWorkspaceBuilds(t *testing.T) {
)
require.NoError(t, err)
require.Len(t, builds, 0)
// Should never be nil for API consistency
require.NotNil(t, builds)
builds, err = client.WorkspaceBuilds(ctx,
codersdk.WorkspaceBuildsRequest{WorkspaceID: workspace.ID, Since: database.Now().Add(-time.Hour)},