From 63572d9f5370a860653adf9ff61256a7aed1724c Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Thu, 19 Dec 2024 13:49:01 +0400 Subject: [PATCH] fix: loosen timing checks for heartbeats (#15923) Fixes #15782. I believe that Windows doesn't always have high-resolution timers available, so this PR loosens the check for PG Coordinator heartbeats, to avoid flakes like: https://github.com/coder/coder/actions/runs/12397381823/job/34607639048 --- enterprise/tailnet/pgcoord_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/enterprise/tailnet/pgcoord_test.go b/enterprise/tailnet/pgcoord_test.go index 1971534f44..5dffdf030b 100644 --- a/enterprise/tailnet/pgcoord_test.go +++ b/enterprise/tailnet/pgcoord_test.go @@ -410,7 +410,7 @@ func TestPGCoordinatorSingle_SendsHeartbeats(t *testing.T) { } require.Greater(t, heartbeats[0].Sub(start), time.Duration(0)) require.Greater(t, heartbeats[1].Sub(start), time.Duration(0)) - return assert.Greater(t, heartbeats[1].Sub(heartbeats[0]), tailnet.HeartbeatPeriod*9/10) + return assert.Greater(t, heartbeats[1].Sub(heartbeats[0]), tailnet.HeartbeatPeriod*3/4) }, testutil.WaitMedium, testutil.IntervalMedium) }