synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-09 11:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(agent): remove unused token debug handler (#12602)

Browse Source
This commit is contained in:
Cian Johnston
2024-03-15 09:43:36 +00:00
committed by GitHub
parent 8d7819f6d6
commit 653ddccd8e
3 changed files with 0 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
agent/agent.go
View File

@ -1714,18 +1714,6 @@ func (a *agent) HandleHTTPDebugManifest(w http.ResponseWriter, r *http.Request)
} }
} }
func (a *agent) HandleHTTPDebugToken(w http.ResponseWriter, r *http.Request) {
tok := a.sessionToken.Load()
if tok == nil {
a.logger.Error(r.Context(), "no session token in-memory")
w.WriteHeader(http.StatusInternalServerError)
_, _ = fmt.Fprintf(w, "no session token in-memory")
return
}
w.WriteHeader(http.StatusOK)
_, _ = fmt.Fprintf(w, *tok)
}
func (a *agent) HandleHTTPDebugLogs(w http.ResponseWriter, r *http.Request) { func (a *agent) HandleHTTPDebugLogs(w http.ResponseWriter, r *http.Request) {
logPath := filepath.Join(a.logDir, "coder-agent.log") logPath := filepath.Join(a.logDir, "coder-agent.log")
f, err := os.Open(logPath) f, err := os.Open(logPath)
@ -1753,7 +1741,6 @@ func (a *agent) HTTPDebug() http.Handler {
r.Get("/debug/magicsock", a.HandleHTTPDebugMagicsock) r.Get("/debug/magicsock", a.HandleHTTPDebugMagicsock)
r.Get("/debug/magicsock/debug-logging/{state}", a.HandleHTTPMagicsockDebugLoggingState) r.Get("/debug/magicsock/debug-logging/{state}", a.HandleHTTPMagicsockDebugLoggingState)
r.Get("/debug/manifest", a.HandleHTTPDebugManifest) r.Get("/debug/manifest", a.HandleHTTPDebugManifest)
r.Get("/debug/token", a.HandleHTTPDebugToken)
r.NotFound(func(w http.ResponseWriter, r *http.Request) { r.NotFound(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusNotFound) w.WriteHeader(http.StatusNotFound)
_, _ = w.Write([]byte("404 not found")) _, _ = w.Write([]byte("404 not found"))

16
agent/agent_test.go
View File

@ -2088,22 +2088,6 @@ func TestAgent_DebugServer(t *testing.T) {
require.NotNil(t, v) require.NotNil(t, v)
}) })
t.Run("Token", func(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitLong)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, srv.URL+"/debug/token", nil)
require.NoError(t, err)
res, err := srv.Client().Do(req)
require.NoError(t, err)
require.Equal(t, http.StatusOK, res.StatusCode)
defer res.Body.Close()
resBody, err := io.ReadAll(res.Body)
require.NoError(t, err)
require.Equal(t, "token", string(resBody))
})
t.Run("Logs", func(t *testing.T) { t.Run("Logs", func(t *testing.T) {
t.Parallel() t.Parallel()

1
agent/api.go
View File

@ -40,7 +40,6 @@ func (a *agent) apiHandler() http.Handler {
r.Get("/debug/magicsock", a.HandleHTTPDebugMagicsock) r.Get("/debug/magicsock", a.HandleHTTPDebugMagicsock)
r.Get("/debug/magicsock/debug-logging/{state}", a.HandleHTTPMagicsockDebugLoggingState) r.Get("/debug/magicsock/debug-logging/{state}", a.HandleHTTPMagicsockDebugLoggingState)
r.Get("/debug/manifest", a.HandleHTTPDebugManifest) r.Get("/debug/manifest", a.HandleHTTPDebugManifest)
r.Get("/debug/token", a.HandleHTTPDebugToken)
return r return r
} }