synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Close parameter file before test exit (#2694)

Browse Source 
Flake seen here:
https://github.com/coder/coder/runs/7079404499?check_suite_focus=true
This commit is contained in:
Kyle Carberry
2022-06-27 14:42:26 -05:00
committed by GitHub
parent abfae1b4aa
commit 69f27efead
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cli/create_test.go
View File

@ -273,7 +273,9 @@ func TestCreate(t *testing.T) {
})
tempDir := t.TempDir()
parameterFile, _ := os.CreateTemp(tempDir, "testParameterFile*.yaml")
parameterFile, err := os.CreateTemp(tempDir, "testParameterFile*.yaml")
require.NoError(t, err)
defer parameterFile.Close()
_, _ = parameterFile.WriteString(fmt.Sprintf("%s: %q", echo.ParameterExecKey, echo.ParameterError("fail")))
// The template import job should end up failed, but we need it to be
@ -288,7 +290,7 @@ func TestCreate(t *testing.T) {
cmd.SetIn(pty.Input())
cmd.SetOut(pty.Output())
err := cmd.Execute()
err = cmd.Execute()
require.Error(t, err)
require.ErrorContains(t, err, "dry-run workspace")
})