synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-06 15:41:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(coderd): move test location to ignore Australia time saving error (#15013)

Browse Source 
A test is currently failing because it relies on Sidney Tz.

from the internet : 

```
Daylight Saving Time begins at 2 am (AEST) on the first Sunday in October and ends at 3 am (Australian Eastern Daylight Time) on the first Sunday in April.
```

Due to that - there's one hour missing in the tests - and the test `6
days are acceptable` is failing.

Changing to another timezone to fix the situation, it would require a
longer-term solution or making sure it cannot happen anymore.
This commit is contained in:
Vincent Vielle
2024-10-07 21:10:01 +02:00
committed by GitHub
parent 3046f5c959
commit 6bf73a5964
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
coderd/insights_internal_test.go
View File

@ -179,17 +179,17 @@ func Test_parseInsightsInterval_week(t *testing.T) {
t.Parallel()
layout := insightsTimeLayout
sydneyLoc, err := time.LoadLocation("Australia/Sydney") // Random location
losAngelesLoc, err := time.LoadLocation("America/Los_Angeles") // Random location
require.NoError(t, err)
now := time.Now().In(sydneyLoc)
now := time.Now().In(losAngelesLoc)
t.Logf("now: %s", now)
y, m, d := now.Date()
today := time.Date(y, m, d, 0, 0, 0, 0, sydneyLoc)
today := time.Date(y, m, d, 0, 0, 0, 0, losAngelesLoc)
t.Logf("today: %s", today)
thisHour := time.Date(y, m, d, now.Hour(), 0, 0, 0, sydneyLoc)
thisHour := time.Date(y, m, d, now.Hour(), 0, 0, 0, losAngelesLoc)
t.Logf("thisHour: %s", thisHour)
twoHoursAgo := thisHour.Add(-2 * time.Hour)
t.Logf("twoHoursAgo: %s", twoHoursAgo)