synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-08 11:39:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(audit): only generate diff on request success (#4253)

Browse Source
This commit is contained in:
Colin Adler
2022-09-28 17:28:33 -05:00
committed by GitHub
parent 9339d597b9
commit 6d2b7ea3ba
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
coderd/audit/request.go
View File

@ -110,8 +110,18 @@ func InitRequest[T Auditable](w http.ResponseWriter, p *RequestParams) (*Request
return
}
diff := Diff(p.Audit, req.Old, req.New)
diffRaw, _ := json.Marshal(diff)
var diffRaw = []byte("{}")
// Only generate diffs if the request succeeded.
if sw.Status < 400 {
diff := Diff(p.Audit, req.Old, req.New)
var err error
diffRaw, err = json.Marshal(diff)
if err != nil {
p.Log.Warn(logCtx, "marshal diff", slog.Error(err))
diffRaw = []byte("{}")
}
}
ip, err := parseIP(p.Request.RemoteAddr)
if err != nil {