From 7b393526c56a067dcad3d977b0753dcb166d39be Mon Sep 17 00:00:00 2001 From: Bruno Quaresma Date: Thu, 26 May 2022 13:42:25 -0500 Subject: [PATCH] fix: Fix sensitive parameters being displayed in the new workspace form (#1796) --- site/src/xServices/createWorkspace/createWorkspaceXService.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/site/src/xServices/createWorkspace/createWorkspaceXService.ts b/site/src/xServices/createWorkspace/createWorkspaceXService.ts index 610bf8c7a2..13ac3f7911 100644 --- a/site/src/xServices/createWorkspace/createWorkspaceXService.ts +++ b/site/src/xServices/createWorkspace/createWorkspaceXService.ts @@ -156,7 +156,9 @@ export const createWorkspaceMachine = createMachine( selectedTemplate: (_, event) => event.template, }), assignTemplateSchema: assign({ - templateSchema: (_, event) => event.data, + // Only show parameters that are allowed to be overridden. + // CLI code: https://github.com/coder/coder/blob/main/cli/create.go#L152-L155 + templateSchema: (_, event) => event.data.filter((param) => param.allow_override_source), }), assignCreateWorkspaceRequest: assign({ createWorkspaceRequest: (_, event) => event.request,