synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: fetch templates by id without lock in dbfake (#6351)

Browse Source 
See https://github.com/coder/coder/actions/runs/4276632002/jobs/7444857508
This commit is contained in:
Kyle Carberry
2023-02-26 15:29:43 -06:00
committed by GitHub
parent acbe968f41
commit 7c46f76c82
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
coderd/database/dbfake/databasefake.go
View File

@ -936,7 +936,7 @@ func (q *fakeQuerier) GetAuthorizedWorkspaces(ctx context.Context, arg database.
} }
if arg.TemplateName != "" { if arg.TemplateName != "" {
template, err := q.GetTemplateByID(ctx, workspace.TemplateID) template, err := q.getTemplateByIDNoLock(ctx, workspace.TemplateID)
if err == nil && !strings.EqualFold(arg.TemplateName, template.Name) { if err == nil && !strings.EqualFold(arg.TemplateName, template.Name) {
continue continue
} }
@ -1617,10 +1617,14 @@ func (q *fakeQuerier) ParameterValues(_ context.Context, arg database.ParameterV
return parameterValues, nil return parameterValues, nil
} }
func (q *fakeQuerier) GetTemplateByID(_ context.Context, id uuid.UUID) (database.Template, error) { func (q *fakeQuerier) GetTemplateByID(ctx context.Context, id uuid.UUID) (database.Template, error) {
q.mutex.RLock() q.mutex.RLock()
defer q.mutex.RUnlock() defer q.mutex.RUnlock()
return q.getTemplateByIDNoLock(ctx, id)
}
func (q *fakeQuerier) getTemplateByIDNoLock(_ context.Context, id uuid.UUID) (database.Template, error) {
for _, template := range q.templates { for _, template := range q.templates {
if template.ID == id { if template.ID == id {
return template, nil return template, nil