synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-03 16:13:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Compile rego once to save CPU cycles in testing (#4169)

Browse Source 
Compiling rego isn't very fast, so this should speed up tests in CI!
This commit is contained in:
Kyle Carberry
2022-09-23 11:26:04 -05:00
committed by GitHub
parent 1e1967e0db
commit 8738755ffc
4 changed files with 33 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
coderd/rbac/authz_internal_test.go
View File

@ -40,10 +40,8 @@ func (w fakeObject) RBACObject() Object {
func TestFilterError(t *testing.T) {
t.Parallel()
auth, err := NewAuthorizer()
require.NoError(t, err)
_, err = Filter(context.Background(), auth, uuid.NewString(), []string{}, ScopeAll, ActionRead, []Object{ResourceUser, ResourceWorkspace})
auth := NewAuthorizer()
_, err := Filter(context.Background(), auth, uuid.NewString(), []string{}, ScopeAll, ActionRead, []Object{ResourceUser, ResourceWorkspace})
require.ErrorContains(t, err, "object types must be uniform")
}
@ -160,8 +158,7 @@ func TestFilter(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
defer cancel()
auth, err := NewAuthorizer()
require.NoError(t, err, "new auth")
auth := NewAuthorizer()
scope := ScopeAll
if tc.Scope != "" {
@ -742,8 +739,7 @@ type authTestCase struct {
func testAuthorize(t *testing.T, name string, subject subject, sets ...[]authTestCase) {
t.Helper()
authorizer, err := NewAuthorizer()
require.NoError(t, err)
authorizer := NewAuthorizer()
for _, cases := range sets {
for i, c := range cases {
c := c