synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-15 22:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Never run v2 migrations on v1 database (#6438)

Browse Source
This commit is contained in:
Steven Masley
2023-03-06 13:49:03 -06:00
committed by GitHub
parent 22e3ff96be
commit 8a6635bf5f
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
coderd/database/migrations/migrate.go
View File

@ -25,6 +25,13 @@ func setup(db *sql.DB) (source.Driver, *migrate.Migrate, error) {
return nil, nil, xerrors.Errorf("create iofs: %w", err) return nil, nil, xerrors.Errorf("create iofs: %w", err)
} }
// migration_cursor is a v1 migration table. If this exists, we're on v1.
// Do no run v2 migrations on a v1 database!
row := db.QueryRowContext(ctx, "SELECT * FROM migration_cursor;")
if row.Err() == nil {
return nil, nil, xerrors.Errorf("currently connected to a Coder v1 database, aborting database setup")
}
// there is a postgres.WithInstance() method that takes the DB instance, // there is a postgres.WithInstance() method that takes the DB instance,
// but, when you close the resulting Migrate, it closes the DB, which // but, when you close the resulting Migrate, it closes the DB, which
// we don't want. Instead, create just a connection that will get closed // we don't want. Instead, create just a connection that will get closed