synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: avoid logging http.ErrAbortHandler panics (#6686)

Browse Source
This commit is contained in:
Dean Sheather
2023-03-20 20:51:21 -07:00
committed by GitHub
parent 4bf012cefb
commit 8aae0b64d3
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
coderd/httpmw/recover.go
View File

@ -15,7 +15,13 @@ func Recover(log slog.Logger) func(h http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
defer func() { defer func() {
r := recover() r := recover()
if r != nil {
// Reverse proxying (among other things) may panic with
// http.ErrAbortHandler when the request is aborted. It's not a
// real panic so we shouldn't log them.
//
//nolint:errorlint // this is how the stdlib does the check
if r != nil && r != http.ErrAbortHandler {
log.Warn(context.Background(), log.Warn(context.Background(),
"panic serving http request (recovered)", "panic serving http request (recovered)",
slog.F("panic", r), slog.F("panic", r),