From 8cd6a6fb353c61183edccc6cba3ee66b05314f05 Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Tue, 11 Feb 2025 11:33:08 +0200 Subject: [PATCH] Prevent prebuild deletion from failing because old params were passed in Signed-off-by: Danny Kopping --- coderd/prebuilds/controller.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/coderd/prebuilds/controller.go b/coderd/prebuilds/controller.go index 473e16c508..352cce829d 100644 --- a/coderd/prebuilds/controller.go +++ b/coderd/prebuilds/controller.go @@ -417,8 +417,13 @@ func (c Controller) provision(ctx context.Context, db database.Store, prebuildID Initiator(PrebuildOwnerUUID). ActiveVersion(). VersionID(template.ActiveVersionID). - MarkPrebuild(). - RichParameterValues(params) + MarkPrebuild() + + // We only inject the required params when the prebuild is being created. + // This mirrors the behaviour of regular workspace deletion (see cli/delete.go). + if transition != database.WorkspaceTransitionDelete { + builder = builder.RichParameterValues(params) + } _, provisionerJob, _, err := builder.Build( ctx,