synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent dbmem reading other groups when getting group members (#14581)

Browse Source
This commit is contained in:
Ethan
2024-09-09 14:33:11 +10:00
committed by GitHub
parent 6b9e1d4771
commit 918bea18c1
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
coderd/database/dbmem/dbmem.go
View File

@ -2653,14 +2653,14 @@ func (q *FakeQuerier) GetGroupMembersByGroupID(ctx context.Context, id uuid.UUID
var groupMembers []database.GroupMember var groupMembers []database.GroupMember
for _, member := range q.groupMembers { for _, member := range q.groupMembers {
groupMember, err := q.getGroupMemberNoLock(ctx, member.UserID, member.GroupID)
if errors.Is(err, errUserDeleted) {
continue
}
if err != nil {
return nil, err
}
if member.GroupID == id { if member.GroupID == id {
groupMember, err := q.getGroupMemberNoLock(ctx, member.UserID, member.GroupID)
if errors.Is(err, errUserDeleted) {
continue
}
if err != nil {
return nil, err
}
groupMembers = append(groupMembers, groupMember) groupMembers = append(groupMembers, groupMember)
} }
} }