synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: change promtheus label to 'tx_id' (#15238)

Browse Source 
the 'id' label was not coming through. Maybe it's reserved? Or used in
the chain somewhere.
This commit is contained in:
Steven Masley
2024-10-25 18:50:42 -04:00
committed by GitHub
parent e03ef62a13
commit 9308331d9a
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
coderd/database/dbmetrics/dbmetrics_test.go
View File

@ -22,7 +22,7 @@ func TestInTxMetrics(t *testing.T) {
successLabels := prometheus.Labels{
"success": "true",
"id": "",
"tx_id": "",
}
const inTxHistMetricName = "coderd_db_tx_duration_seconds"
const inTxCountMetricName = "coderd_db_tx_executions_count"
@ -86,7 +86,7 @@ func TestInTxMetrics(t *testing.T) {
// Check that the metrics are registered
inTxHistMetric := promhelp.HistogramValue(t, reg, inTxHistMetricName, prometheus.Labels{
"success": "false",
"id": id,
"tx_id": id,
})
require.NotNil(t, inTxHistMetric)
require.Equal(t, uint64(1), inTxHistMetric.GetSampleCount())
@ -94,7 +94,7 @@ func TestInTxMetrics(t *testing.T) {
inTxCountMetric := promhelp.CounterValue(t, reg, inTxCountMetricName, prometheus.Labels{
"success": "false",
"retries": "1",
"id": id,
"tx_id": id,
})
require.NotNil(t, inTxCountMetric)
require.Equal(t, 1, inTxCountMetric)