diff --git a/.github/actions/setup-go/action.yaml b/.github/actions/setup-go/action.yaml index 819bc27e0e..a05fc271eb 100644 --- a/.github/actions/setup-go/action.yaml +++ b/.github/actions/setup-go/action.yaml @@ -9,7 +9,7 @@ runs: using: "composite" steps: - name: Setup Go - uses: buildjet/setup-go@v4 + uses: buildjet/setup-go@v5 with: go-version: ${{ inputs.version }} diff --git a/.github/actions/setup-node/action.yaml b/.github/actions/setup-node/action.yaml index d6929381dd..c0a5477ec1 100644 --- a/.github/actions/setup-node/action.yaml +++ b/.github/actions/setup-node/action.yaml @@ -11,11 +11,11 @@ runs: using: "composite" steps: - name: Install pnpm - uses: pnpm/action-setup@v2 + uses: pnpm/action-setup@v3 with: version: 8 - name: Setup Node - uses: buildjet/setup-node@v3 + uses: buildjet/setup-node@v4.0.1 with: node-version: 18.19.0 # See https://github.com/actions/setup-node#caching-global-packages-data diff --git a/.github/codecov.yml b/.github/codecov.yml deleted file mode 100644 index 902dae6be2..0000000000 --- a/.github/codecov.yml +++ /dev/null @@ -1,43 +0,0 @@ -codecov: - require_ci_to_pass: false - notify: - after_n_builds: 5 - -comment: false - -github_checks: - annotations: false - -coverage: - range: 50..75 - round: down - precision: 2 - status: - patch: - default: - informational: yes - project: - default: - target: 65% - informational: true - -ignore: - # This is generated code. - - coderd/database/models.go - - coderd/database/queries.sql.go - - coderd/database/databasefake - # These are generated or don't require tests. - - cmd - - coderd/tunnel - - coderd/database/dump - - coderd/database/postgres - - peerbroker/proto - - provisionerd/proto - - provisionersdk/proto - - scripts - - site/.storybook - - rules.go - # Packages used for writing tests. - - cli/clitest - - coderd/coderdtest - - pty/ptytest diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c279360cea..2314763cae 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -269,16 +269,6 @@ jobs: id: test shell: bash run: | - # Code coverage is more computationally expensive and also - # prevents test caching, so we disable it on alternate operating - # systems. - if [ "${{ matrix.os }}" == "ubuntu-latest" ]; then - echo "cover=true" >> $GITHUB_OUTPUT - export COVERAGE_FLAGS='-covermode=atomic -coverprofile="gotests.coverage" -coverpkg=./...' - else - echo "cover=false" >> $GITHUB_OUTPUT - fi - # if macOS, install google-chrome for scaletests. As another concern, # should we really have this kind of external dependency requirement # on standard CI? @@ -297,7 +287,7 @@ jobs: fi export TS_DEBUG_DISCO=true gotestsum --junitfile="gotests.xml" --jsonfile="gotests.json" \ - --packages="./..." -- $PARALLEL_FLAG -short -failfast $COVERAGE_FLAGS + --packages="./..." -- $PARALLEL_FLAG -short -failfast - name: Upload test stats to Datadog timeout-minutes: 1 @@ -307,19 +297,6 @@ jobs: with: api-key: ${{ secrets.DATADOG_API_KEY }} - - name: Check code coverage - uses: codecov/codecov-action@v4 - # This action has a tendency to error out unexpectedly, it has - # the `fail_ci_if_error` option that defaults to `false`, but - # that is no guarantee, see: - # https://github.com/codecov/codecov-action/issues/788 - continue-on-error: true - if: steps.test.outputs.cover && github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork - with: - token: ${{ secrets.CODECOV_TOKEN }} - files: ./gotests.coverage - flags: unittest-go-${{ matrix.os }} - test-go-pg: runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }} needs: @@ -355,19 +332,6 @@ jobs: with: api-key: ${{ secrets.DATADOG_API_KEY }} - - name: Check code coverage - uses: codecov/codecov-action@v4 - # This action has a tendency to error out unexpectedly, it has - # the `fail_ci_if_error` option that defaults to `false`, but - # that is no guarantee, see: - # https://github.com/codecov/codecov-action/issues/788 - continue-on-error: true - if: github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork - with: - token: ${{ secrets.CODECOV_TOKEN }} - files: ./gotests.coverage - flags: unittest-go-postgres-linux - test-go-race: runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }} needs: changes @@ -414,19 +378,6 @@ jobs: - run: pnpm test:ci --max-workers $(nproc) working-directory: site - - name: Check code coverage - uses: codecov/codecov-action@v4 - # This action has a tendency to error out unexpectedly, it has - # the `fail_ci_if_error` option that defaults to `false`, but - # that is no guarantee, see: - # https://github.com/codecov/codecov-action/issues/788 - continue-on-error: true - if: github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork - with: - token: ${{ secrets.CODECOV_TOKEN }} - files: ./site/coverage/lcov.info - flags: unittest-js - test-e2e: runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-16vcpu-ubuntu-2204' || 'ubuntu-latest' }} needs: changes