synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: block creating oidc users when oidc has not been configured (#14064)

Browse Source
This commit is contained in:
Ethan
2024-08-01 13:30:10 +10:00
committed by GitHub
parent 7a4737cf76
commit 956d0cb042
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
coderd/users.go
View File

@ -464,6 +464,12 @@ func (api *API) postUser(rw http.ResponseWriter, r *http.Request) {
} }
loginType = database.LoginTypePassword loginType = database.LoginTypePassword
case codersdk.LoginTypeOIDC: case codersdk.LoginTypeOIDC:
if api.OIDCConfig == nil {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
Message: "You must configure OIDC before creating OIDC users.",
})
return
}
loginType = database.LoginTypeOIDC loginType = database.LoginTypeOIDC
case codersdk.LoginTypeGithub: case codersdk.LoginTypeGithub:
loginType = database.LoginTypeGithub loginType = database.LoginTypeGithub
@ -471,6 +477,7 @@ func (api *API) postUser(rw http.ResponseWriter, r *http.Request) {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{ httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
Message: fmt.Sprintf("Unsupported login type %q for manually creating new users.", req.UserLoginType), Message: fmt.Sprintf("Unsupported login type %q for manually creating new users.", req.UserLoginType),
}) })
return
} }
user, _, err := api.CreateUser(ctx, api.Database, CreateUserRequest{ user, _, err := api.CreateUser(ctx, api.Database, CreateUserRequest{