synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-08 11:39:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: add tag and value in validation error details (#1760)

Browse Source 
* add tag and value in validation error details

* fix unit tests and linter

* add quotes around value

* fix unit tests
This commit is contained in:
Abhineet Jain
2022-05-27 10:13:13 -04:00
committed by GitHub
parent c5f06acb01
commit 9929189c45
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
coderd/httpapi/httpapi.go
View File

@ -104,7 +104,7 @@ func Read(rw http.ResponseWriter, r *http.Request, value interface{}) bool {
for _, validationError := range validationErrors {
apiErrors = append(apiErrors, Error{
Field: validationError.Field(),
Detail: validationError.Tag(),
Detail: fmt.Sprintf("Validation failed for tag %q with value: \"%v\"", validationError.Tag(), validationError.Value()),
})
}
Write(rw, http.StatusBadRequest, Response{

8
coderd/httpapi/httpapi_test.go
View File

@ -58,7 +58,7 @@ func TestRead(t *testing.T) {
var validate toValidate
require.True(t, httpapi.Read(rw, r, &validate))
require.Equal(t, validate.Value, "hi")
require.Equal(t, "hi", validate.Value)
})
t.Run("ValidateFailure", func(t *testing.T) {
@ -75,8 +75,8 @@ func TestRead(t *testing.T) {
err := json.NewDecoder(rw.Body).Decode(&v)
require.NoError(t, err)
require.Len(t, v.Errors, 1)
require.Equal(t, v.Errors[0].Field, "value")
require.Equal(t, v.Errors[0].Detail, "required")
require.Equal(t, "value", v.Errors[0].Field)
require.Equal(t, "Validation failed for tag \"required\" with value: \"\"", v.Errors[0].Detail)
})
}
@ -140,7 +140,7 @@ func TestReadUsername(t *testing.T) {
r := httptest.NewRequest("POST", "/", bytes.NewBuffer(data))
var validate toValidate
require.Equal(t, httpapi.Read(rw, r, &validate), testCase.Valid)
require.Equal(t, testCase.Valid, httpapi.Read(rw, r, &validate))
})
}
}