synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-08 11:39:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove duplication from language of query param error (#9069)

Browse Source
This commit is contained in:
Kyle Carberry
2023-08-13 11:47:44 -05:00
committed by GitHub
parent 1629a2a4ee
commit 9a13814b46
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
coderd/httpapi/queryparams.go
View File

@ -45,7 +45,7 @@ func (p *QueryParamParser) ErrorExcessParams(values url.Values) {
if _, ok := p.Parsed[k]; !ok {
p.Errors = append(p.Errors, codersdk.ValidationError{
Field: k,
Detail: fmt.Sprintf("Query param %q is not a valid query param", k),
Detail: fmt.Sprintf("%q is not a valid query param", k),
})
}
}

6
coderd/searchquery/search_test.go
View File

@ -142,7 +142,7 @@ func TestSearchWorkspace(t *testing.T) {
{
Name: "ExtraKeys",
Query: `foo:bar`,
ExpectedErrorContains: `Query param "foo" is not a valid query param`,
ExpectedErrorContains: `"foo" is not a valid query param`,
},
}
@ -239,7 +239,7 @@ func TestSearchAudit(t *testing.T) {
{
Name: "ExtraKeys",
Query: `foo:bar`,
ExpectedErrorContains: `Query param "foo" is not a valid query param`,
ExpectedErrorContains: `"foo" is not a valid query param`,
},
{
Name: "Dates",
@ -370,7 +370,7 @@ func TestSearchUsers(t *testing.T) {
{
Name: "ExtraKeys",
Query: `foo:bar`,
ExpectedErrorContains: `Query param "foo" is not a valid query param`,
ExpectedErrorContains: `"foo" is not a valid query param`,
},
}