diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go index d00c4ec3bc..38b1742725 100644 --- a/coderd/database/queries.sql.go +++ b/coderd/database/queries.sql.go @@ -14947,7 +14947,7 @@ WHERE -- Filter by owner_name AND CASE WHEN $8 :: text != '' THEN - workspaces.owner_id = (SELECT id FROM users WHERE lower(owner_username) = lower($8) AND deleted = false) + workspaces.owner_id = (SELECT id FROM users WHERE lower(users.username) = lower($8) AND deleted = false) ELSE true END -- Filter by template_name diff --git a/coderd/database/queries/workspaces.sql b/coderd/database/queries/workspaces.sql index 08e795d7a2..369333a5ea 100644 --- a/coderd/database/queries/workspaces.sql +++ b/coderd/database/queries/workspaces.sql @@ -233,7 +233,7 @@ WHERE -- Filter by owner_name AND CASE WHEN @owner_username :: text != '' THEN - workspaces.owner_id = (SELECT id FROM users WHERE lower(owner_username) = lower(@owner_username) AND deleted = false) + workspaces.owner_id = (SELECT id FROM users WHERE lower(users.username) = lower(@owner_username) AND deleted = false) ELSE true END -- Filter by template_name diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go index c24afc67de..0a4e106701 100644 --- a/coderd/workspaces_test.go +++ b/coderd/workspaces_test.go @@ -1313,6 +1313,39 @@ func TestWorkspaceFilterManual(t *testing.T) { require.NoError(t, err) require.Len(t, res.Workspaces, 0) }) + t.Run("Owner", func(t *testing.T) { + t.Parallel() + client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true}) + user := coderdtest.CreateFirstUser(t, client) + otherUser, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID, rbac.RoleOwner()) + version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) + coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID) + template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) + + // Add a non-matching workspace + coderdtest.CreateWorkspace(t, otherUser, template.ID) + + workspaces := []codersdk.Workspace{ + coderdtest.CreateWorkspace(t, client, template.ID), + coderdtest.CreateWorkspace(t, client, template.ID), + } + + ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) + defer cancel() + + sdkUser, err := client.User(ctx, codersdk.Me) + require.NoError(t, err) + + // match owner name + res, err := client.Workspaces(ctx, codersdk.WorkspaceFilter{ + FilterQuery: fmt.Sprintf("owner:%s", sdkUser.Username), + }) + require.NoError(t, err) + require.Len(t, res.Workspaces, len(workspaces)) + for _, found := range res.Workspaces { + require.Equal(t, found.OwnerName, sdkUser.Username) + } + }) t.Run("IDs", func(t *testing.T) { t.Parallel() client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true})