synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-15 22:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Increase disconnectTimeout to reduce test flakes (#26)

Browse Source 
* test: Increase disconnectTimeout to reduce test flakes

WebRTC uses UDP, which means a network connection is never open or closed. It uses timeouts to determine connection state; on a slow CI runner, these timeouts could be reached. Increasing this timeout should reduce flakes, but is unlikely to remove this flake entirely.

* Fix close after offline

* Run tests in parallel
This commit is contained in:
Kyle Carberry
2022-01-14 10:12:07 -06:00
committed by GitHub
parent 423611b001
commit a461bc1454
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/coder.yaml vendored
View File

@ -130,7 +130,7 @@ jobs:
- run: - run:
gotestsum --jsonfile="gotests.json" --packages="./..." -- gotestsum --jsonfile="gotests.json" --packages="./..." --
-covermode=atomic -coverprofile="gotests.coverage" -timeout=3m -covermode=atomic -coverprofile="gotests.coverage" -timeout=3m
-count=3 -race -count=3 -race -parallel=2
- uses: codecov/codecov-action@v2 - uses: codecov/codecov-action@v2
with: with:

5
peer/conn_test.go
View File

@ -23,7 +23,7 @@ import (
) )
const ( const (
disconnectedTimeout = time.Millisecond * 200 disconnectedTimeout = time.Second
failedTimeout = disconnectedTimeout * 5 failedTimeout = disconnectedTimeout * 5
keepAliveInterval = time.Millisecond * 2 keepAliveInterval = time.Millisecond * 2
) )
@ -89,6 +89,7 @@ func TestConn(t *testing.T) {
sch, err := server.Accept(context.Background()) sch, err := server.Accept(context.Background())
require.NoError(t, err) require.NoError(t, err)
defer sch.Close()
_ = cch.Close() _ = cch.Close()
_, err = sch.Read(make([]byte, 4)) _, err = sch.Read(make([]byte, 4))
@ -102,6 +103,7 @@ func TestConn(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
sch, err := server.Accept(context.Background()) sch, err := server.Accept(context.Background())
require.NoError(t, err) require.NoError(t, err)
defer sch.Close()
err = wan.Stop() err = wan.Stop()
require.NoError(t, err) require.NoError(t, err)
@ -117,6 +119,7 @@ func TestConn(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
sch, err := server.Accept(context.Background()) sch, err := server.Accept(context.Background())
require.NoError(t, err) require.NoError(t, err)
defer sch.Close()
go func() { go func() {
for i := 0; i < 1024; i++ { for i := 0; i < 1024; i++ {
_, err := cch.Write(make([]byte, 4096)) _, err := cch.Write(make([]byte, 4096))