synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-13 21:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: concurrent writes to executor stats (#7731)

Browse Source 
Signed-off-by: Spike Curtis <spike@coder.com>
This commit is contained in:
Spike Curtis
2023-06-01 09:23:51 +04:00
committed by GitHub
parent 9810339fd6
commit a46e8f2e49
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
coderd/autobuild/executor/lifecycle_executor.go
View File

@ -3,6 +3,7 @@ package executor
import ( import (
"context" "context"
"database/sql" "database/sql"
"sync"
"sync/atomic" "sync/atomic"
"time" "time"
@ -89,6 +90,8 @@ func (e *Executor) runOnce(t time.Time) Stats {
stats := Stats{ stats := Stats{
Transitions: make(map[uuid.UUID]database.WorkspaceTransition), Transitions: make(map[uuid.UUID]database.WorkspaceTransition),
} }
// we build the map of transitions concurrently, so need a mutex to serialize writes to the map
statsMu := sync.Mutex{}
defer func() { defer func() {
stats.Elapsed = time.Since(t) stats.Elapsed = time.Since(t)
stats.Error = err stats.Error = err
@ -188,7 +191,9 @@ func (e *Executor) runOnce(t time.Time) Stats {
) )
return nil return nil
} }
statsMu.Lock()
stats.Transitions[ws.ID] = validTransition stats.Transitions[ws.ID] = validTransition
statsMu.Unlock()
log.Info(e.ctx, "scheduling workspace transition", slog.F("transition", validTransition)) log.Info(e.ctx, "scheduling workspace transition", slog.F("transition", validTransition))