synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent terminal being created twice (#10200)

Browse Source 
I missed this in code review.
This commit is contained in:
Asher
2023-10-11 12:47:32 -08:00
committed by GitHub
parent 301c045aad
commit a67a5a8105
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
site/src/pages/TerminalPage/TerminalPage.tsx
View File

@ -154,7 +154,7 @@ const TerminalPage: FC = () => {
// Create the terminal!
useEffect(() => {
if (!xtermRef.current) {
if (!xtermRef.current || config.isLoading) {
return;
}
const terminal = new XTerm.Terminal({
@ -210,7 +210,7 @@ const TerminalPage: FC = () => {
window.removeEventListener("resize", listener);
terminal.dispose();
};
}, [config.data, sendEvent, xtermRef, handleWebLink]);
}, [config.data, config.isLoading, sendEvent, xtermRef, handleWebLink]);
// Triggers the initial terminal connection using
// the reconnection token and workspace name found