synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-03 16:13:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: disable authz-header in all builds (#17409)

Browse Source 
Header payload being large is causing some issues in dev builds. Another
method of opting in needs to be determined
This commit is contained in:
Steven Masley
2025-04-15 20:22:21 -05:00
committed by GitHub
parent 70b113de7b
commit a7646d1524
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
coderd/coderd.go
View File

@ -464,8 +464,16 @@ func New(options *Options) *API {
r := chi.NewRouter()
// We add this middleware early, to make sure that authorization checks made
// by other middleware get recorded.
//nolint:revive,staticcheck // This block will be re-enabled, not going to remove it
if buildinfo.IsDev() {
r.Use(httpmw.RecordAuthzChecks)
// TODO: Find another solution to opt into these checks.
// If the header grows too large, it breaks `fetch()` requests.
// Temporarily disabling this until we can find a better solution.
// One idea is to include checking the request for `X-Authz-Record=true`
// header. To opt in on a per-request basis.
// Some authz calls (like filtering lists) might be able to be
// summarized better to condense the header payload.
// r.Use(httpmw.RecordAuthzChecks)
}
ctx, cancel := context.WithCancel(context.Background())