synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-15 22:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Add omitempty for proper latency type (#3850)

Browse Source 
This was causing an error on the frontend, because this value can be nil!
This commit is contained in:
Kyle Carberry
2022-09-02 17:05:27 -05:00
committed by GitHub
parent 2e1db6cc63
commit ac50070713
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
codersdk/workspaceresources.go
View File

@ -59,7 +59,7 @@ type WorkspaceAgent struct {
Version string `json:"version"`
Apps []WorkspaceApp `json:"apps"`
// DERPLatency is mapped by region name (e.g. "New York City", "Seattle").
DERPLatency map[string]DERPRegion `json:"latency"`
DERPLatency map[string]DERPRegion `json:"latency,omitempty"`
}
type WorkspaceAgentResourceMetadata struct {

2
site/src/api/typesGenerated.ts
View File

@ -536,7 +536,7 @@ export interface WorkspaceAgent {
readonly directory?: string
readonly version: string
readonly apps: WorkspaceApp[]
readonly latency: Record<string, DERPRegion>
readonly latency?: Record<string, DERPRegion>
}
// From codersdk/workspaceagents.go

8
site/src/components/Resources/ResourceAgentLatency.tsx
View File

@ -10,9 +10,13 @@ export interface ResourceAgentLatencyProps {
export const ResourceAgentLatency: React.FC<ResourceAgentLatencyProps> = (props) => {
const styles = useStyles()
if (!props.latency) {
return null
}
if (Object.keys(props.latency).length === 0) {
return null
}
const latency = props.latency
return (
<div className={styles.root}>
<div className={styles.title}>
@ -24,10 +28,10 @@ export const ResourceAgentLatency: React.FC<ResourceAgentLatencyProps> = (props)
</HelpTooltipText>
</HelpTooltip>
</div>
{Object.keys(props.latency)
{Object.keys(latency)
.sort()
.map((region) => {
const value = props.latency[region]
const value = latency[region]
return (
<div key={region} className={styles.region}>
<b>{region}:</b>&nbsp;{Math.round(value.latency_ms * 100) / 100} ms