synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 14:17:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(coderd/database): improve data exclusion in UpsertTemplateUsageStats (#12764)

Browse Source 
The PostgreSQL query analyzer wasn't able to eliminate the agent stats without re-introducing this filter.

Before: https://explain.dalibo.com/plan/21h7gb4f4bef391g
After: https://explain.dalibo.com/plan/721ec1cccee91egc
This commit is contained in:
Mathias Fredriksson
2024-03-26 17:21:05 +02:00
committed by GitHub
parent f418ece9ae
commit ae0ee622bb
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
coderd/database/queries.sql.go
View File

@ -2760,7 +2760,9 @@ WITH
JOIN JOIN
workspace_agent_stats AS was workspace_agent_stats AS was
ON ON
date_trunc('minute', was.created_at) = mb.minute_bucket was.created_at >= (SELECT t FROM latest_start)
AND was.created_at < NOW()
AND date_trunc('minute', was.created_at) = mb.minute_bucket
AND was.template_id = mb.template_id AND was.template_id = mb.template_id
AND was.user_id = mb.user_id AND was.user_id = mb.user_id
AND was.connection_median_latency_ms >= 0 AND was.connection_median_latency_ms >= 0

4
coderd/database/queries/insights.sql
View File

@ -599,7 +599,9 @@ WITH
JOIN JOIN
workspace_agent_stats AS was workspace_agent_stats AS was
ON ON
date_trunc('minute', was.created_at) = mb.minute_bucket was.created_at >= (SELECT t FROM latest_start)
AND was.created_at < NOW()
AND date_trunc('minute', was.created_at) = mb.minute_bucket
AND was.template_id = mb.template_id AND was.template_id = mb.template_id
AND was.user_id = mb.user_id AND was.user_id = mb.user_id
AND was.connection_median_latency_ms >= 0 AND was.connection_median_latency_ms >= 0