diff --git a/coderd/presets_test.go b/coderd/presets_test.go index ffe51787d5..2d048abf69 100644 --- a/coderd/presets_test.go +++ b/coderd/presets_test.go @@ -15,6 +15,14 @@ import ( ) func TestTemplateVersionPresets(t *testing.T) { + // TODO (sasswart): test case: what if immutable parameters are used in the preset? + // TODO (sasswart): test case: what if presets are defined for a template version with no params? + // TODO (sasswart): test case: what if a non active version is selected? + // TODO (sasswart): test case: what if a preset is selected that has no parameters? + // TODO (sasswart): what if we have preset params and autofill params on the same param? + // TODO (sasswart): test case: if we move from preset to no preset, do we reset the params? + // If so, how should it behave? Reset to initial value? reset to last set value? + // TODO (sasswart): test case: rich parameters // TODO (sasswart): Test case: what if a user tries to read presets or preset parameters from a different org? t.Parallel() diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx index 0d770b6cc0..fccea627e4 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx @@ -164,15 +164,6 @@ export const CreateWorkspacePageView: FC = ({ ); useEffect(() => { - // TODO (sasswart): test case: what if immutable parameters are used in the preset? - // TODO (sasswart): test case: what if presets are defined for a template version with no params? - // TODO (sasswart): test case: what if a non active version is selected? - // TODO (sasswart): test case: what if a preset is selected that has no parameters? - // TODO (sasswart): what if we have preset params and autofill params on the same param? - // TODO (sasswart): test case: if we move from preset to no preset, do we reset the params? - // If so, how should it behave? Reset to initial value? reset to last set value? - // TODO (sasswart): test case: rich parameters - const selectedPresetOption = presetOptions[selectedPresetIndex]; let selectedPreset: TypesGen.Preset | undefined; for (const preset of presets) {