From b4c29f34c3c0fa7adbeaff00882f7f873e1d36c2 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Mon, 12 Sep 2022 11:01:42 -0500 Subject: [PATCH] fix: Always use UTC time when inserting stats (#4009) Fixes a flake reported by @mafredri --- coderd/templates_test.go | 2 +- coderd/workspaceagents.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/coderd/templates_test.go b/coderd/templates_test.go index 1e6d37b7a0..d3bcbd47dc 100644 --- a/coderd/templates_test.go +++ b/coderd/templates_test.go @@ -665,6 +665,6 @@ func TestTemplateDAUs(t *testing.T) { workspaces, err = client.Workspaces(ctx, codersdk.WorkspaceFilter{}) require.NoError(t, err) assert.WithinDuration(t, - time.Now(), workspaces[0].LastUsedAt, time.Minute, + database.Now(), workspaces[0].LastUsedAt, time.Minute, ) } diff --git a/coderd/workspaceagents.go b/coderd/workspaceagents.go index bb48da0bab..ee61fee555 100644 --- a/coderd/workspaceagents.go +++ b/coderd/workspaceagents.go @@ -848,7 +848,7 @@ func (api *API) workspaceAgentReportStats(rw http.ResponseWriter, r *http.Reques _, err = api.Database.InsertAgentStat(ctx, database.InsertAgentStatParams{ ID: uuid.New(), - CreatedAt: time.Now(), + CreatedAt: database.Now(), AgentID: workspaceAgent.ID, WorkspaceID: build.WorkspaceID, UserID: workspace.OwnerID, @@ -865,7 +865,7 @@ func (api *API) workspaceAgentReportStats(rw http.ResponseWriter, r *http.Reques err = api.Database.UpdateWorkspaceLastUsedAt(ctx, database.UpdateWorkspaceLastUsedAtParams{ ID: build.WorkspaceID, - LastUsedAt: time.Now(), + LastUsedAt: database.Now(), }) if err != nil { httpapi.Write(rw, http.StatusBadRequest, codersdk.Response{