From b55a7a8b78eec065fbd8eb763916285c472cc3e0 Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Wed, 7 Aug 2024 11:19:31 -0500 Subject: [PATCH] chore: delete user codersdk to support status code regression (#14173) * chore: delete user codersdk to support status code regression * Update codersdk/users.go Co-authored-by: Kayla Washburn-Love --------- Co-authored-by: Kayla Washburn-Love --- codersdk/users.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/codersdk/users.go b/codersdk/users.go index 4de5457edc..a715194c11 100644 --- a/codersdk/users.go +++ b/codersdk/users.go @@ -309,7 +309,9 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error { return err } defer res.Body.Close() - if res.StatusCode != http.StatusOK { + // Check for a 200 or a 204 response. 2.14.0 accidentally included a 204 response, + // which was a breaking change, and reverted in 2.14.1. + if res.StatusCode != http.StatusOK && res.StatusCode != http.StatusNoContent { return ReadBodyAsError(res) } return nil